-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test with Python 3.13.1 #2678
Conversation
Can you explain a little more how you found this and how this cpython change breaks this test? Just making sure this isn't actually hiding some problem in wxPython. Is this the error you're trying to fix?
|
Sure :) I am a packager in (open)SUSE, my colleague updated Python 3.13 from 3.13.0 to 3.13.1 and wxPython tests started to fail. When we reverted back to Python 3.13.0, the tests were OK again.
Yes, this is the one. it is similar to the issue they had in neuronsimulator/nrn@9821eaf, so I also fixed it in the same way. |
So, I think this is actually a bug in wxPython that was exposed by this CPython change. Working on figuring out how to fix it. |
This does not only affect tests, but also application software.
Without the modification:
Unfortunately I was not able to produce a minimal code sample that would show the same behaviour. References: |
Is it only happening when GetChildren is involved? |
Well, for several kinds of iterators:
With a small code sample, I could not provoke the fail with |
@swt2c : could it be related? python/cpython#128161 There is a code example which can also be contained by placing a It can be fixed by adding an
So, probably |
Yes, the issue is that the iterator objects (e.g., CommandList_iterator) don't implement |
This should resolve the issue: #2680 |
Hi, thanks for being active on this! The new PR also works for me, so I guess this PR should be closed? |
Tests stopped working with recent Python 3.13, see python/cpython#125846. This change fixes them.