Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify haveWheel condition in setup.py #2691

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

echoix
Copy link
Contributor

@echoix echoix commented Feb 8, 2025

Following #2687, where the wheel dependency has been changed to use the setuptools recommended approach, as the old pattern would have been removed in October 2025, this PR removes the haveWheel condition from the setup.py. (Unindent code where needed)

In the same depreciation issue handling, the wheel dependency (that was installed through pip), was needed before setuptools 70.1 as it provided the bdist_wheel implementation. Since we already require that minimum setuptools, drop the wheel dependency.

Historical note

This project used to contain the implementation of the setuptools bdist_wheel command, but as of setuptools v70.1, it no longer needs wheel installed for that to work. Thus, you should install this only if you intend to use the wheel command line tool!

From https://pypi.org/project/wheel/

Note that pip wheel doesn't require our project to install wheel to work as before.

Remove wheel devel dependency
@swt2c swt2c merged commit 4954266 into wxWidgets:master Feb 9, 2025
13 checks passed
@echoix echoix deleted the simplify-haveWheel-setup.py branch February 9, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants