Skip to content

Commit

Permalink
docs: move TODO closer to where it should be done
Browse files Browse the repository at this point in the history
  • Loading branch information
c-git committed Dec 23, 2024
1 parent d46d987 commit 8315d9a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 0 additions & 1 deletion crates/ws-auth/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use wykies_shared::host_branch::HostId;
pub enum WebSocketAuthError {
/// Client was not expected to be trying to connect
#[error("Unexpected Client")]
// TODO 1: Get client to handle this error better as it might happen under reasonable circumstances
UnexpectedClient {
client_identifier: HostId,
ws_id: WsId,
Expand Down
2 changes: 2 additions & 0 deletions crates/wykies-client-core/src/client/websocket.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ async fn do_connect_ws<F: WakeFn>(
ws_url: String,
wake_up: F,
) -> anyhow::Result<WebSocketConnection> {
// TODO 1: Hand WebSocketAuthError::UnexpectedClient as this can happen under reasonable circumstances

// Get token from response passed in
let token = extract_token(response).await?;

Expand Down

0 comments on commit 8315d9a

Please sign in to comment.