Avoid errors with undefined populator, selector #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons I could not determine, and which disappear whenever you add a debugger to the mix (that is, it is a race condition), The populator and helper members are sometimes undefined causing errors. In addition, this code makes sure we don't get the entire hierarchy if more than one parent matches the selector, for we most certainly don't want more than one popup. Fixes alohaeditor#408.
| # Hide all popovers except for the current one maybe? | ||
| $el = jQuery(rangeObject.getCommonAncestorContainer()) | ||
| $el = $el.parents(helper.selector) if not $el.is(helper.selector) | ||
| $el = $el.parents(helper.selector).eq(0) if not $el.is(helper.selector) |
There was a problem hiding this comment.
Any reason for .eq(0) instead of .first()?
There was a problem hiding this comment.
Nothing specific, I just don't have first() near the top of my mental cheatsheet :-) Isn't it the same thing anyway? first() probably reads easier though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I could not determine, and which disappear whenever you add a
debugger to the mix (that is, it is a race condition), The populator and helper
members are sometimes undefined causing errors. In addition, this code makes
sure we don't get the entire hierarchy if more than one parent matches
the selector, for we most certainly don't want more than one popup.