-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pagy has deprecated the size array format and replaced it with an integer. This is more sensible but doesn't fit in with the GOV.UK Design System's guidance that says: > For smaller screens, show page numbers for: > > * the current page > * previous and next pages > * first and last pages > > For larger screens, show page numbers for: > > * the current page > * at least one page immediately before and after the current page > * first and last pages The numeric size doesn't provide quite enough control over what's displayed before/after the current page. As a result we have to enable the Size Extra[0] functionality, which allows us to use the old implementation. Also, Pagy has replaced the items param with limit[1], so the specs have been updated accordingly. [0] https://ddnexus.github.io/pagy/docs/extras/size/ [1] https://ddnexus.github.io/pagy/changelog/#version-900
- Loading branch information
1 parent
a220959
commit 57465fd
Showing
4 changed files
with
5 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,3 +4,4 @@ | |
require "govuk/components/engine" | ||
require "html_attributes_utils" | ||
require "pagy" | ||
require "pagy/extras/size" |
2 changes: 1 addition & 1 deletion
2
spec/components/govuk_component/configuration/pagination_component_configuration_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters