Merge pull request #251 from DFE-Digital/fix-breadcrumb-current-level…

…-rendering-bug Fix breadcrumb text entries when key is symbol
x-govuk · Sep 13, 2021 · d2e96b1 · d2e96b1
2 parents 5d994f8 + 29f1742
commit d2e96b1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/app/components/govuk_component/breadcrumbs_component.rb b/app/components/govuk_component/breadcrumbs_component.rb
@@ -33,7 +33,7 @@ def build_list_item(text, link = nil)
     if link.present?
       list_item { link_to(text, link, class: "govuk-breadcrumbs__link") }
     else
-      list_item(aria: { current: "page" }) { text }
+      list_item(aria: { current: "page" }) { text.to_s }
     end
   end
 

diff --git a/spec/dummy/app/views/demos/examples/_breadcrumbs.html.erb b/spec/dummy/app/views/demos/examples/_breadcrumbs.html.erb
@@ -1,12 +1,17 @@
 <%= example_heading('Breadcrumbs') %>
 
+<p class="govuk-inset-text">
+  To render the current level as text instead of a link you can pass either
+  <code>nil</code> or an empty string.
+</p>
+
 <%= render "shared/example",
   title: 'Breadcrumbs',
   example: <<~BREADCRUMBS
     render GovukComponent::BreadcrumbsComponent.new(breadcrumbs: {
       'Level one': '/level-one/',
       'Level two': '/level-one/level-two/',
-      'Level three': '/level-one/level-two/level-three'
+      'Level three': nil
     })
   BREADCRUMBS
 %>