Add notification banner to primary nav component #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims to alert users that the Primary navigation component will be removed in future, and users should use the Service navigation component from the GOV.UK Design System instead.
|
Love it; far more tactical than my diversion. We can add deprecation notices in a later minor release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to alert users that the Primary navigation component will be removed in future, and users should use the Service navigation component from the GOV.UK Design System instead.
We could add this straight away, do a minor release which mentions the deprecation in the release notes, and then remove the component completely in the next major release, in #246?
Screenshot