Update head.html #995
Merged
Update head.html #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linked the favicon in the `<head>` of the site. Browsers usually find it automatically if in the root, but as it isn't located in the root, it isn't being detected and doesn't work in my Chrome version.
|
@frankieroberto No idea why this is failing, seems like a fairly straightforward change, I don't think there's much I can do to fix it, to be honest? |
|
@Nooshu I’ve had a longstanding issue where GitHub workflow which checks all the JSON is valid and which pretty-formats it and then commits any changes doesn’t work with pull requests open to forks, I think due to a permissions issue. I've just fixed it in #997 though - so now it'll check the JSON is valid but won't try and pretty-format it if the pull request is from a fork. Hopefully. 🤞 |
frankieroberto
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to the favicon in the
<head>of the site. Browsers usually find it automatically if in the root directory, but as it isn't located there, it isn't being detected and doesn't work in my latest Chrome version.Example below:
