Add post on improving accessibility of Rails forms #153
Conversation
peteryates
force-pushed
the
add-finishing-touches-for-forms-post
branch
from
fc7cc3b to
185fdaf
Compare
| If there are errors we can add the 'Error:' prefix: | ||
|
|
||
| ```ruby | ||
| def page_title(text, error: false) |
There was a problem hiding this comment.
Any reason not to recommend our existing helper here? https://govuk-components.netlify.app/helpers/title-with-error-prefix/ 😄
There was a problem hiding this comment.
🤦♂️
Oh dear, I forgot it was there. I'll amend the post 😅 Thank you!
There was a problem hiding this comment.
Haha, doh! I’m not sure it’s yet widely used in DfE repos as it was added after most of them already had their own helper?
| This causes a few problems. | ||
|
|
||
| The GOV.UK design system includes some complex rules around linking to fields from the error summary. For example, errors on checkbox or radio button fields should link to the first checkbox or radio button. |
There was a problem hiding this comment.
This bit isn’t explained in the post. Worth adding a separate section to explain link_errors: true?
There was a problem hiding this comment.
Yeah, this post needs three things; two seems too few!
There was a problem hiding this comment.
Header image too! 😀
|
I've got a great idea for an illustration… will rustle something up in a bit! |
|
|
||
| The [GOV.UK formbuilder](https://govuk-form-builder.netlify.app) makes it easy for Ruby on Rails developers to build forms that follow the rules set out in the [GOV.UK design system](https://design-system.service.gov.uk/). | ||
|
|
||
| It takes care of the markup, provides a nice API for customising the fields to meet the needs of your service and takes care of clearly dispalying any error messages. |
| url: https://github.com/peteryates | ||
| --- | ||
|
|
||
| The [GOV.UK formbuilder](https://govuk-form-builder.netlify.app) makes it easy for Ruby on Rails developers to build forms that follow the rules set out in the [GOV.UK design system](https://design-system.service.gov.uk/). |
There was a problem hiding this comment.
| The [GOV.UK formbuilder](https://govuk-form-builder.netlify.app) makes it easy for Ruby on Rails developers to build forms that follow the rules set out in the [GOV.UK design system](https://design-system.service.gov.uk/). | |
| The [GOV.UK formbuilder](https://govuk-form-builder.netlify.app) makes it easy for Ruby on Rails developers to build forms that follow the rules set out in the [GOV.UK Design System](https://design-system.service.gov.uk/). |
|
@peteryates Added an illustration – home you like it!? Also simplified the side-by-side example image, making it less busy and a smaller file size. |
paulrobertlloyd
changed the title
|
I love the graphic at the top 🤩 Thanks for the feedback, I think I've addressed it and added the third section on |
| end | ||
| ``` | ||
|
|
||
| Now when there's a validation error, regardless of whether the user is an admin or not the error summary will link to the first option. It's a good idea to write some tests to ensure future changes don't affect it. |
There was a problem hiding this comment.
Does this need a concluding paragraph? Something about how these finishing touches will make the world of difference to users or something (trite?) like that?
There was a problem hiding this comment.
The problem is we'd need a heading to make it clear the summary is for the post rather than for the third tip.
| end | ||
| ``` | ||
|
|
||
| This would make it impossible for the error summary to accurately link to the first check box or radio button without repeating the logic --- an approach that's going to lead to bugs when it's updated in one place but not the other. |
There was a problem hiding this comment.
How does --- render?
Co-authored-by: Paul Robert Lloyd <[email protected]>
No description provided.