-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for column major devices, mix stride = smi #25
base: master
Are you sure you want to change the base?
Conversation
Please remove the |
src/scarlett_mixer.c
Outdated
if ((opts & OPT_DETECT) && d.matrix_mix_column_major) { | ||
d.matrix_mix_stride = d.smi; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matrix_in_stride
is not set anymore (removed above). Also please use tabs for indent (and space to align).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be set in an earlier branch. In my case, it's set correctly to 1 (instead of 10 being set here)
int row = 4 * floor (o / 5); // beware of bleed into Hi-Z, Pads | ||
int oc = o % 5; | ||
int row = 0; // beware of bleed into Hi-Z, Pads | ||
int oc = o; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks layout for the 18i20 -- rows have to be split after 5 stereo pairs, see 27df030
#6 (comment)
#6 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is also interesting -- can we somehow keep both layouts?
It splits Headphone 2R, S/PDIF L,R to row 4 and overlaps with the pads.
Sorry I cannot do a screenshot at the moment (meh Wayland), but it looks just right for 18i8 :) |
No description provided.