Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for column major devices, mix stride = smi #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yatli
Copy link

@yatli yatli commented Aug 25, 2021

No description provided.

@x42
Copy link
Owner

x42 commented Aug 25, 2021

Please remove the .ccls file, if at all the change should be in a separate commit.

Comment on lines 631 to 634
if ((opts & OPT_DETECT) && d.matrix_mix_column_major) {
d.matrix_mix_stride = d.smi;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matrix_in_stride is not set anymore (removed above). Also please use tabs for indent (and space to align).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be set in an earlier branch. In my case, it's set correctly to 1 (instead of 10 being set here)

Comment on lines -1318 to +1320
int row = 4 * floor (o / 5); // beware of bleed into Hi-Z, Pads
int oc = o % 5;
int row = 0; // beware of bleed into Hi-Z, Pads
int oc = o;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks layout for the 18i20 -- rows have to be split after 5 stereo pairs, see 27df030
#6 (comment)
#6 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is also interesting -- can we somehow keep both layouts?
It splits Headphone 2R, S/PDIF L,R to row 4 and overlaps with the pads.

@yatli
Copy link
Author

yatli commented Aug 25, 2021

Sorry I cannot do a screenshot at the moment (meh Wayland), but it looks just right for 18i8 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants