Gradle Build Chain Improvements #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building currently fails because of this, let's finish improving building first, then fix the javadoc thing
Cache does weird things sometimes
Fixed: Jetbrains annotation not being exposed to underlying libraries Fixed: Version not being properly detected
Fixed: Version not being properly parsed to the plugin.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle Build Chain Improvements
foojay-resolver-conventionpluginTODO
Let's use this PR to further improve the Gradle build chain until you are satisfied, upon which we can merge this PR. I now added the Jetbrains annotations library as a dependency to your API module but marked it as compile only for your platform implementations, as the API module already shades the Jetbrains annotations, and thus it's not necessary to add the same dependency twice.