CP-49689: remove reverse dependency on SR from xs_errors #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xs_errors is one of the lowest level modules in the SM codebase yet it imports the SR module, in order to access the SROSError class, which is one of the highest level modules. The SR subclasses then import the xs_errors module. Correct this inverted dependency chain by moving the declaration of the error class into xs_errors and fix up the usage. Signed-off-by: Mark Syms <[email protected]>
Signed-off-by: Mark Syms <[email protected]>
KevinLCtx
approved these changes
Jun 3, 2024
TimSmithCtx
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xs_errors is one of the lowest level modules in the SM codebase yet it
imports the SR module, in order to access the SROSError class, which
is one of the highest level modules. The SR subclasses then import the
xs_errors module.
Correct this inverted dependency chain by moving the declaration of
the error class into xs_errors and fix up the usage.
Also load the XML error message declarations from a sibling file to
simplify the unit tests and remove a hard coded path, which might
in the future change.