Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-399643 Use full paths when stopping fairlock on upgrade #708

Merged
merged 1 commit into from
Sep 26, 2024
Merged

CA-399643 Use full paths when stopping fairlock on upgrade #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions mk/sm.spec.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,13 +237,16 @@ Manager and some other packages
%{_unitdir}/[email protected]
%{_libexecdir}/fairlock

%posttrans fairlock
%post fairlock
## On upgrade, shut down existing lock services so new ones will
## be started. There should be no locks held during upgrade operations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What allows to ensure that there's no lock at the time of the RPM update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toolstack assures us they do not perform RPM upgrades while simultaneously performing storage management operations. Anyone on the command line who chooses to do an RPM upgrade in the middle of a disk shuffle should expect many more problems than just the odd dropped lock :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Is it the fact that the host is disabled during the upgrades which ensures this?

## so this is safe.
if [ $1 -gt 1 ];
then
systemctl stop $(systemctl list-units fairlock@* --all --no-legend | cut -d' ' -f1)
/usr/bin/systemctl list-units fairlock@* --all --no-legend | /usr/bin/cut -d' ' -f1 | while read service;
do
/usr/bin/systemctl stop "$service"
done
fi

%changelog
Expand Down
Loading