CP-52744: Thread TraceContext as JSON inside debug_info
#6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBuica
force-pushed
the
private/dbuica/tracecontext-in-debuginfo
branch
from
9bc7086 to
39d5dfc
Compare
edwintorok
reviewed
Jan 15, 2025
GabrielBuica
force-pushed
the
private/dbuica/tracecontext-in-debuginfo
branch
from
5aec6e6 to
ff91579
Compare
mg12
reviewed
Jan 21, 2025
mg12
reviewed
Jan 21, 2025
mg12
reviewed
Jan 21, 2025
mg12
reviewed
Jan 21, 2025
mg12
reviewed
Jan 21, 2025
GabrielBuica
force-pushed
the
private/dbuica/tracecontext-in-debuginfo
branch
from
ff91579 to
fc6d6e0
Compare
mg12
approved these changes
Jan 23, 2025
|
Note that we should merge the current |
Adds functionality to marshal and unmarshal `TraceContext` in the tracing library. Instead of passing only the `traceparent` in `debug_info`, the entire `TraceContext` is now passed as JSON. This change enables the transfer of baggage across xenopsd boundaries, improving tracing propagation and debugging capabilities. This should also enable later use of `baggage` as means of passing the thread classification between components. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/tracecontext-in-debuginfo
branch
from
fc6d6e0 to
421fabf
Compare
Refresh the trace_context with the correct traceparent when creating a span with `start_tracing_helper` in `context.ml`. This ensures the tracing of the context has the correct parent. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/tracecontext-in-debuginfo
branch
from
421fabf to
99afa2e
Compare
|
feature/perf has been merged to master, so this PR is unblocked and can now be merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality to marshal and unmarshal
TraceContextin the tracing library.Instead of passing only the
traceparentindebug_info, the entireTraceContextis now passed as JSON.This change enables the transfer of baggage across xenopsd boundaries, improving tracing propagation and debugging capabilities. This should also enable later use of
baggageas means of passing the thread classification between components.Latest BVT+BST:211567