numa: do not fail when loading invalid distance matrices #6242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead disable NUMA for the host Fixes xapi-project#6240 Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
private/paus/numaybe
branch
from
73bf03a to
9f4977b
Compare
psafont
changed the title
last-genius
approved these changes
Jan 21, 2025
contificate
approved these changes
Jan 21, 2025
lindig
approved these changes
Jan 21, 2025
| if not numa_matrix_is_reasonable then ( | ||
| D.info | ||
| "Not enabling NUMA: the ACPI SLIT table contains values that are \ | ||
| invalid." ; |
There was a problem hiding this comment.
The wording could be more in line with the test: the table is implausible.
changlei-li
reviewed
Jan 22, 2025
| @@ -78,7 +78,7 @@ module NUMA : sig | |||
| (** A NUMA node index. Distinct from an int to avoid mixing with CPU numbers *) | |||
| type node = private Node of int | |||
|
|
|||
| val make : distances:int array array -> cpu_to_node:int array -> t | |||
| val make : distances:int array array -> cpu_to_node:int array -> t option | |||
There was a problem hiding this comment.
I see the [invalid_arg] is not raised any more, should the comment(L100) be updated?
There was a problem hiding this comment.
I'll take a look, thanks
|
In light of the comment in the original issue, I want to make the code cope with unreachable numa nodes. I'll reopen the PR once it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead disable NUMA for the host
Fixes #6240