Fix for the 7k siteURL page scrape for WetVR Scraper #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to a counter based method that stops when a p tag with "Latest" no longer present on the siteURL page. This is the end of valid sceneURLs. Also had to add in a method to prevent multiple firings of the OnHTML callback. This method repeats with 13 siteURL visits every time which is the current number of valid siteURLs for WetVR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to a counter based method that stops when a p tag with "Latest" no longer present on the siteURL page. This is the end of valid sceneURLs. Also had to add in a method to prevent multiple firings of the OnHTML callback. This method repeats with 13 siteURL visits every time which is the current number of valid siteURLs for WetVR.
Tested with blank XBVR instance scraped 24 scene with limit scraper on and scraped 136 scenes with limit scraper off. It all appears to be functional