LethalHardCoreVR Scraper Rebuild for React #1824
Closed
+197
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Their some optimizations that could be done in the XPATH query. It usually can pull all scenes in the first scrape. Occasionally something will slow down the network and cause a misfire. And result in a few mixed scenes. Needs to be test on a slow network. Currently hangs if something really goes wrong and can't find wants it looking for
Remove some old diag code. Correct docker install. Due to ubuntu being ubuntu we need to install chrome direct
pops64
force-pushed
the
LH-Scraper-Redo
branch
from
d3cc6eb to
8e682ae
Compare
|
I'm sorry, but I won't merge this. I don't want to add that big of a dependency (and maintenance liability) for a single scraper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully functionally again. Works 99% of the time. Cards aren't loaded in sequence and my current logic only checks if the last card is loaded before scroll the page to load more. This will occasionally cause a card that is late on loading to be missed as it is scrolled out of range of the viewport. (2 times out of the 10+ times I have ran test) A re scrape usually will pick theses missed ones back up.
The dockerFile breaks arm docker images. As it uses amd chrome. Probably a way to install arm chrome or may be a non issue. Their appears no way to install chromium on docker Ubuntu that I could find as chromium for Ubuntu's repo throws an error requiring it to be installed via snap.
Functionality that has been removed. Gallery Images aren't scraped. This requires scraping the photos index pages as their doesn't appear any link from the main scene page to the photos. The synopsis as been removed from LH.
Things left todo
Devices I have tested it on