Fix StashDB DB locked errors #1826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the stashDB scraper is called directly via `scrape.StashDb()` through `api.StashDB()` and not though `tasks.Scrape()` All the locked code that is associated with `tasks.Scrape()` is not used. So DB acitions in `stashDB()` are being blocked. I believe this is causing errors when multiple process attempt to run as other processes lock the DB but stashDB does not and doesn't check either. Also updated the start code to bring it more in line with how `tasks.Scrape()` starts as `scrapeID` and `siteID` are only used in this one instance. Testing required to confirm squash
|
Not squashed yet. I am not sure where the DB is being locked up. Its happening on a |
|
I will close this for now and make a new PR once I squash this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the stashDB scraper is called directly via
scrape.StashDb()throughapi.StashDB()and not thoughtasks.Scrape()All the locked code that is associated withtasks.Scrape()is not used. So DB acitions instashDB()are being blocked. I believe this is causing errors when multiple process attempt to run as other processes lock the DB but stashDB does not and doesn't check either.Also updated the start code to bring it more in line with how
tasks.Scrape()starts asscrapeIDandsiteIDare only used in this one instance.Testing required to confirm squash