Exclude non-FOSS GMS deps from google-shortcuts #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to hold on merging this for a week or so, because we just started running beta testing on the Play store, and i don't want to stop that to include this. I'm also not comfortable sending this to prod without testing, so what i propose is do the release on Play store without this, then merge this (if my tests don't show up anything) and then F-Droid can pick it up. |
|
That being said... this might not be enough, see comments: https://gitlab.com/fdroid/fdroiddata/-/commit/a2baa158a7dfd8d31c2bb3d88025aea81a52e042 |
|
Any other suggestions? I'm not familiar with f-droids build process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #912