Add buttonmap for DualShock4 connecting to macOS via BT. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested using DualShock 4 (2nd gen) controller connected via bluetooth to a Macbook running macOS 11.2.3. It advertises itself as `"DUALSHOCK 4 Wireless Controller", axes: 6, hats: 0, buttons: 14`, not as "Wireless Controller" specified in the existing button map https://github.com/xbmc/peripheral.joystick/blob/79d166a1519305f05ebf2db24a7fbd6bb7633083/peripheral.joystick/resources/buttonmaps/xml/cocoa/Wireless_Controller_v054C_p09CC_14b_6a.xml So even though the vid/pid and the rest are the same, the existing button map is not used per https://github.com/xbmc/peripheral.joystick/blob/79d166a1519305f05ebf2db24a7fbd6bb7633083/src/storage/Device.cpp#L34 As Joystick families (#32) do not seem to be fully implemented (adding a new entry to the joystickfamilies.xml didn't have an effect and I don't see where it's used in the code), I solve this by duplicating the existing button map with a different name.
|
Thanks! Until joystick families are implemented, the intention is to have a new XML file for every driver name, because XML is relatively cheap for now. There are many improvements we could make to further the vision of intelligently mapping unseen controllers. Joystick families sprung up entirely as a way to re-use any data we could from the old buttonmaps before the new joystick system in v17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested using DualShock 4 (2nd gen) controller connected via bluetooth to a Macbook running macOS 11.2.3.
It advertises itself as
"DUALSHOCK 4 Wireless Controller", axes: 6, hats: 0, buttons: 14, not as "Wireless Controller" specified in the existing button map.So even though the vid/pid and the rest are the same, the existing button map is not used.
As Joystick families (#32) do not seem to be fully implemented (adding a new entry to the joystickfamilies.xml didn't have an effect and I don't see where it's used in the code), I solve this by duplicating the existing button map with a different name.