Return error if session is not connected #60
Merged
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
om26er
reviewed
Oct 23, 2024
session.go
Outdated
| @@ -308,8 +308,15 @@ func (s *Session) processIncomingMessage(msg messages.Message) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (s *Session) IsConnected() bool { | |||
There was a problem hiding this comment.
Suggested change
| func (s *Session) IsConnected() bool { | |
| func (s *Session) Connected() bool { |
muzzammilshahid
force-pushed
the
is-session-connected
branch
from
5f4f295 to
f9fc4f3
Compare
om26er
requested changes
Oct 23, 2024
session.go
Outdated
| func (s *Session) Register(procedure string, handler InvocationHandler, | ||
| options map[string]any) (*Registration, error) { | ||
| if !s.Connected() { | ||
| return nil, fmt.Errorf("session not connected") |
There was a problem hiding this comment.
the error message should be tailered for each type of WAMP actions.
Suggested change
| return nil, fmt.Errorf("session not connected") | |
| return nil, fmt.Errorf("cannot register procedure: session not established") |
muzzammilshahid
force-pushed
the
is-session-connected
branch
from
f9fc4f3 to
f856e58
Compare
om26er
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.