make random_state sklearn compliant #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
random_state
can only be an integer value where<= 0
uses the system time and> 0
sets the seed.This PR makes Python library
random_state
sklearn compliant:random_state
with an integer value< 0
uses system time as seed;random_state
with an integer value>= 0
will set the seed;random_state = None
to-1
and uses system time as seed;Note that are still some situations where setting the random number seed will not result in reproducible results, such as when using parallel processing and random numbers are used during forward propagation of neural nets (such as dropout layers.)