feat: Async Breakpoint Manager #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle breakpoints in async manner. Better support one (VS Code) to many (Xdebug connections). Handle busy Xdebug connection.
|
Fixes #482 |
…ceptionBreakPointsRequest.
Codecov Report
@@ Coverage Diff @@
## main #550 +/- ##
==========================================
+ Coverage 66.57% 70.00% +3.42%
==========================================
Files 6 7 +1
Lines 1098 1230 +132
Branches 172 193 +21
==========================================
+ Hits 731 861 +130
- Misses 367 369 +2
Continue to review full report at Codecov.
|
…cy issues by queuing changes to map and processing them later.
* Support for notify, breakpoint_get and feature_get. * Set resolved_breakpoints and notify_ok feature. * Handle resolved for line and conditional breakpoints. * Handle breakpoint_resolved notify.
zobo
added a commit
that referenced
this pull request
May 6, 2021
* feat: Async Breakpoint Manager Handle breakpoints in async manner. Better support one (VS Code) to many (Xdebug connections). Handle busy Xdebug connection. * docs: Changelog. * chore: lint * Update vscode-debugprotocol to 1.47.0 and return Breakpoints on setExceptionBreakPointsRequest. * Protect BreakpointAdapter process from re-enty. Prevent map concurrency issues by queuing changes to map and processing them later. * Use the same order of op execution that was added to the queue. * Resolved breakpoints support. * Support for notify, breakpoint_get and feature_get. * Set resolved_breakpoints and notify_ok feature. * Handle resolved for line and conditional breakpoints. * Handle breakpoint_resolved notify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle breakpoints in async manner.
Better support one (VS Code) to many (Xdebug connections).
Handle busy Xdebug connection.