Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2 client id enforcement fix #4

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

santiagomed
Copy link
Collaborator

xurl will fail if you don't have client_id or client_secret only if you try to perform oauth2 flow. This will allow users that don't have client_id or client_secret in their environment and only want to call app-only auth endpoints.

also removed first_oauth2_token() method since it is redundant. We have get_token_store().

…to improve token management and error handling.
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@amisra-work amisra-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@santiagomed santiagomed merged commit b5c8291 into main Dec 18, 2024
2 checks passed
@santiagomed santiagomed deleted the santiagomed/auth-fixes branch December 18, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants