Integer and boolean fixes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think that there is any benefit from using asl.bool (and, if there is, it will be easy enough to revert this change).
alastairreid
force-pushed
the
areid-int-ops2
branch
from
6955d26 to
836e2dc
Compare
superlopuh
reviewed
Jan 15, 2025
asl_xdsl/dialects/asl.py
Outdated
| """A hack to convert !asl.bool to i1 so that we can use scf.if.""" | ||
|
|
||
| name = "asl.bool_to_i1" | ||
| class UnaryIntOp(IRDLOperation): |
There was a problem hiding this comment.
nit:
Suggested change
| class UnaryIntOp(IRDLOperation): | |
| class UnaryIntOp(IRDLOperation, abc.ABC): |
I've found it quite useful to leverage Python's abc module to let both the type-checker and the runtime enforce that classes designed to be abstract aren't instantiated directly, and that abstract methods are implemented by subclasses.
There was a problem hiding this comment.
Sounds good - adding that in an extra commit to this PR
superlopuh
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the head of the areid-mlir branch passes 26 of 119 backend tests. (Set ASL_XDSL_DIR to the xdsl-asl tree and 'make test-backend-mlir')