Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: (x86) Fix register sets test coverage #3866

Merged
merged 6 commits into from
Feb 12, 2025
Merged

backend: (x86) Fix register sets test coverage #3866

merged 6 commits into from
Feb 12, 2025
+34 −4

Conversation

compor
Copy link
Collaborator

@compor compor commented Feb 7, 2025

Resolves #2353

@compor compor added the backend Compiler backend in xDSL label Feb 7, 2025
@compor compor requested review from superlopuh and KGrykiel February 7, 2025 14:39
@compor compor self-assigned this Feb 7, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (12ce9cd) to head (bacfdd7).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3866      +/-   ##
==========================================
- Coverage   91.26%   91.25%   -0.01%     
==========================================
  Files         462      463       +1     
  Lines       57684    57772      +88     
  Branches     5566     5572       +6     
==========================================
+ Hits        52643    52720      +77     
- Misses       3618     3625       +7     
- Partials     1423     1427       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

superlopuh
superlopuh approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo reply from @math-fehr on the exception thing

@compor compor force-pushed the christos/dialects/x86/reg-cover branch from 3adfd30 to bacfdd7 Compare February 10, 2025 10:21
alexarice
alexarice approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to be merged and leave the discussion about diagnostic flags to later

@math-fehr math-fehr self-requested a review February 12, 2025 12:24
math-fehr
math-fehr approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see this!
I think the exception is fine!

@compor
Copy link
Collaborator Author

compor commented Feb 12, 2025

Thanks we can short out the split after

@compor compor merged commit 8863a69 into main Feb 12, 2025
16 checks passed
@compor compor deleted the christos/dialects/x86/reg-cover branch February 12, 2025 13:37
math-fehr added a commit that referenced this pull request Feb 12, 2025
@math-fehr
Revert "backend: (x86) Fix register sets test coverage (#3866)"
3ca1cbb 
This reverts commit 8863a69.
math-fehr added a commit that referenced this pull request Feb 12, 2025
@math-fehr
Revert "backend: (x86) Fix register sets test coverage (#3866)" (#3890)
6ca01f1 
This reverts commit 8863a69.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superlopuh superlopuh superlopuh approved these changes

@alexarice alexarice alexarice approved these changes

@math-fehr math-fehr math-fehr approved these changes

@KGrykiel KGrykiel KGrykiel approved these changes

Assignees

@compor compor

Labels
backend Compiler backend in xDSL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dialects: (x86) fully cover x86 register class with tests
5 participants
@compor @superlopuh @alexarice @math-fehr @KGrykiel