backend: (riscv) use separate indices for j and fj registers #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
AntonLydike,
math-fehr,
qaco and
emmau678
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3885 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 466 466
Lines 57905 57910 +5
Branches 5570 5571 +1
=======================================
+ Hits 52845 52850 +5
Misses 3634 3634
Partials 1426 1426 ☔ View full report in Codecov by Sentry. |
compor
approved these changes
Feb 11, 2025
emmau678
approved these changes
Feb 11, 2025
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
…ject#3885) We currently use the same indices which makes them difficult to distinguish and harder to spot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use the same indices which makes them difficult to distinguish and harder to spot.