docs: Add sympy to dev dependencies #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
6aff0f9 to
eb68acd
Compare
This was referenced Feb 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3886 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 466 466
Lines 57905 57949 +44
Branches 5570 5575 +5
=======================================
+ Hits 52845 52886 +41
- Misses 3634 3635 +1
- Partials 1426 1428 +2 ☔ View full report in Codecov by Sentry. |
compor
approved these changes
Feb 11, 2025
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
eb68acd to
758258b
Compare
math-fehr
changed the title
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
758258b to
3d7e5b1
Compare
|
I moved this to dev dependency instead |
As we are going to merge notebooks that depends on sympy, we need an optional dev dependency. stack-info: PR: #3886, branch: math-fehr/stack/8
|
Might need to redo make venv locally for the lockfile to update |
math-fehr
force-pushed
the
math-fehr/stack/8
branch
from
3d7e5b1 to
0047b1e
Compare
superlopuh
approved these changes
Feb 11, 2025
math-fehr
added a commit
that referenced
this pull request
Feb 12, 2025
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
As we are going to merge notebooks that depends on sympy, we need an optional dev dependency.
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
Stacked PRs: * __->__#3884 * xdslproject#3883 * xdslproject#3882 * xdslproject#3881 * xdslproject#3886 --- --- --- ### docs: Add notebook for defining dialects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
docs: Add sympy to dev dependencies
As we are going to merge notebooks that depends on sympy, we need an
optional dev dependency.