-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: add back benchmark and profiling infrastructure #3889
base: main
Are you sure you want to change the base?
bench: add back benchmark and profiling infrastructure #3889
Conversation
Is there a way to avoid duplicating the files? I was expecting this to be more minimal |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3889 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 466 466
Lines 57949 57949
Branches 5575 5575
=======================================
Hits 52886 52886
Misses 3635 3635
Partials 1428 1428 ☔ View full report in Codecov by Sentry. |
If I remove the benchmarks which parse/lex over all test MLIR files instead of individual ones that should cut down the size a lot? |
OK, this looks a bit more sensible in the number of files changed and shouldn't impact the expressiveness of the tests too much. |
|
||
.PHONY: asv | ||
asv: | ||
cd .. && uv run asv run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this ..
feels a bit fragile, especially repeated at every make target.
Can't we use the --directory
option along with exposing this as a make var along the whole Makefile?
Summary
This PR moves the existing benchmarks and profiling infrastructure from https://github.com/xdslproject/xdsl-bench into the main xDSL repo so they can be used more easily by developers. In addition to this, it restructures and extends them to provide more microbenchmarks, component-level benchmarks, and end-to-end benchmarks.
A full description of the motivate and structure is available in
benchmarks/README.md
.Future work
mlir-opt
installation in CI to generate it on the fly