dialects: (linalg) fix linalg.matmul to correctly store integer arg types
#3903
+28
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
reviewed
Feb 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3903 +/- ##
==========================================
+ Coverage 91.26% 91.29% +0.03%
==========================================
Files 468 466 -2
Lines 57998 58012 +14
Branches 5566 5566
==========================================
+ Hits 52929 52962 +33
+ Misses 3646 3622 -24
- Partials 1423 1428 +5 ☔ View full report in Codecov by Sentry. |
oluwatimilehin
commented
Feb 14, 2025
| // CHECK-GENERIC-NEXT: %45 = "arith.muli"(%42, %44) <{overflowFlags = #arith.overflow<none>}> : (i32, i32) -> i32 | ||
| // CHECK-GENERIC-NEXT: %46 = "arith.addi"(%40, %45) <{overflowFlags = #arith.overflow<none>}> : (i32, i32) -> i32 | ||
| // CHECK-GENERIC-NEXT: "linalg.yield"(%46) : (i32) -> () | ||
| // CHECK-GENERIC-NEXT: ^11(%41 : i8, %42 : i8, %43 : i32, %44 : i32, %45 : i32): |
There was a problem hiding this comment.
@superlopuh @compor Just curious, why do we use integer values here instead of capturing patterns like %{{.*}} ?
There was a problem hiding this comment.
as far as I'm concerned, that's a bug, maybe these should be fixed in this PR
superlopuh
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@superlopuh @compor