Added functionality to remove passwords from clear text and support auditdb runtime credentials #8
Conversation
| ${ddb_audit_pass} | ||
| ${ddb_user} | ||
| ${ddb_pass} | ||
| <#-- |
There was a problem hiding this comment.
Can those lines be removed? Why are they commented out? Looks like a leftover from testing the changes.
| @@ -10,4 +10,18 @@ | |||
|
|
|||
| --> | |||
| <#include "/datical/datical_generic.ftl"> | |||
| <#include "/datical/datical_credentials.bat.ftl"> | |||
| ${ddb_audit_user} | |||
There was a problem hiding this comment.
Are these 4 lines needed? Shouldn't the include be enough? So taking out the assign from the include statement?
| @@ -13,10 +13,12 @@ | |||
|
|
|||
| <#assign login>${deployed.container.home} <#if deployed.container.username?has_content>-un ${environment}:::${deployed.container.username} -pw ${environment}:::${deployed.container.password}</#if></#assign> | |||
|
|
|||
| <#assign login_simple>${deployed.container.home} </#assign> | |||
There was a problem hiding this comment.
Is login still used? If not, why not rename login_simple into login?
| <#include "/datical/datical_generic_undeploy.ftl"> | ||
| <#if previousDeployed.changeids?size gt 0> | ||
| <#list previousDeployed.changeids as changeid> | ||
| <#-- | ||
| ${login} -p ${previousDeployed.targetPath} rollback ${environment} changeid:id=${changeid} | ||
| --> | ||
| ${login} -p ${previousDeployed.targetPath} rollback ${environment} changeid:id=${changeid} |
There was a problem hiding this comment.
Shouldn't this be login_simple?
| <operation>MODIFY</operation> | ||
| </conditions> | ||
| <steps> | ||
| <os-script> |
There was a problem hiding this comment.
Can we do this using a Jython step (maybe using requests). That would remove the dependency on curl.
| @@ -78,7 +78,7 @@ | |||
| </steps> | |||
| </rule> | |||
|
|
|||
|
|
|||
| <!-- | |||
There was a problem hiding this comment.
Why is this rule commented out?
|
Updating files to remove commented code and adopt suggested from jdewinne. |
Modified a number of files in this pull request. These mods tackle two main use cases:
Regarding #1...
For Windows, sensitive output is removed using "@".
For Linux, sensitive output is removed using "/dev/null"
Here is a list of new files added
src/main/resources/datical/datical_credentials.bat.ftl
src/main/resources/datical/datical_credentials.sh.ftl
src/main/resources/datical/daticalweb_status_refresh.bat.ftl
src/main/resources/datical/daticalweb_status_refresh.sh.ftl
Here is a list of existing files that were modified:
modified: src/main/resources/datical/datical_deploy.bat.ftl
modified: src/main/resources/datical/datical_deploy.sh.ftl
modified: src/main/resources/datical/datical_forecast.bat.ftl
modified: src/main/resources/datical/datical_forecast.sh.ftl
modified: src/main/resources/datical/datical_generic.ftl
modified: src/main/resources/datical/datical_status_detail.bat.ftl
modified: src/main/resources/datical/datical_status_detail.sh.ftl
modified: src/main/resources/datical/datical_upload.bat.ftl
modified: src/main/resources/datical/datical_undeploy.bat.ftl
modified: src/main/resources/datical/datical_undeploy.sh.ftl
modified: src/main/resources/synthetic.xml