-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QE-746 As a QE member, I want to containerize Postgres Database clust… #38
base: master
Are you sure you want to change the base?
Conversation
…er for XLD testing, so I can include this platform at every release
# Conflicts: # src/main/kotlin/ai/digital/integration/server/common/domain/Cluster.kt # src/main/kotlin/ai/digital/integration/server/deploy/internals/cluster/DeployDockerClusterHelper.kt # src/main/kotlin/ai/digital/integration/server/deploy/tasks/StartDeployIntegrationServerTask.kt
@@ -71,6 +77,14 @@ open class DeployDockerClusterHelper(val project: Project) { | |||
return "${worker.dockerImage}:${getClusterVersion()}" | |||
} | |||
|
|||
private fun getWorkerJdbcUrl(): String { | |||
var workerJdbcUrl = "postgresql:5432/xld-db" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already not correct, as it depends what database is used, and this config has to be configurable.
private fun getWorkerJdbcUrl(): String { | ||
var workerJdbcUrl = "postgresql:5432/xld-db" | ||
if (isDatabaseLoadBalancerEnabled()) { | ||
workerJdbcUrl = "haproxydb:5000/postgres" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, hard coded url is not acceptable.
|
||
services: | ||
zoo1: | ||
image: zookeeper:3.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has to be configurable
zoo1: | ||
image: zookeeper:3.4 | ||
hostname: zoo1 | ||
container_name: zoo1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the best names even for default value, and they should be also configurable
hostname: zoo1 | ||
container_name: zoo1 | ||
ports: | ||
- 2191:2181 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all this file, all ports which are exposed have to be configurable.
depends_on: | ||
- zoo1 | ||
|
||
zoo3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of nodes and partitions have to be configurable.
I might want not 3 but 5 nodes.
Should be some simple way to specify it in config.
Like partitions: 5
, and all this file is generated. Exposed ports have to be random, and the function used which identifies which port is free now. Check in the code, we have it.
- XL_CLUSTER_MODE=default | ||
- XL_DB_PASSWORD=admin | ||
- XL_DB_USERNAME=postgres | ||
- XL_DB_URL=jdbc:postgresql://haproxydb:5000/postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not good
@@ -8,6 +8,7 @@ import org.gradle.kotlin.dsl.property | |||
open class Cluster(objects: ObjectFactory) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please create a blog post for that to explain on the high level how it works.
…er for XLD testing, so I can include this platform at every release