Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALFREDAPI-545 Defects and improvements v4.1.1 #207

Merged
merged 14 commits into from
May 2, 2024

Conversation

todorinskiz
Copy link
Member

@todorinskiz todorinskiz commented Apr 25, 2024

Includes tickets from https://xenitsupport.jira.com/browse/ALFREDAPI-545 (epic)

@WimCrols this PR is the merge of 3 smaller PRs

Includes:

There are 2 main regressions:

  • Searching on date range breaks the date facet
  • Alfred API does not use the maxFilters configuration to return the pre-configured number of facets, and defaults to 100

codingBenVdS and others added 12 commits April 25, 2024 11:23
ALFREDAPI-521_release [Test] import junit-jupiter:5.7.1

ALFREDAPI-521_release [Test] update upload test task ci

ALFREDAPI-521_release [Test] change testImplementation 'org.junit.jupiter:junit-jupiter for gradle plugin og junit.reporter

ALFREDAPI-521_release [Test] adding mikepenz/action-junit-report@v3

ALFREDAPI-521_release [Test]

ALFREDAPI-521_release [Test] Junit in gradle

ALFREDAPI-521_release [Test] issue ci solved

ALFREDAPI-521_release [Test] test reports

ALFREDAPI-521_release [Update] ci Publish Test Report - new path to include integration test results

ALFREDAPI-521_release [Delete] junit.reporter

ALFREDAPI-521_release [Test] Update path to include integration test

ALFREDAPI-521_release [Test] revert alfresco_version to include all builds

ALFREDAPI-521_release [Undo] Failing tests

ALFREDAPI-521_release [Undo] test code

ALFREDAPI-521_release [Cleanup] to rebase

ALFREDAPI-521_release [Update] Add a 1s delay before searching for results

ALFREDAPI-521_release: skip test for GHA (runs finelocally)

ALFREDAPI-521_release [Update] import @ignore

ALFREDAPI-521_release [Update] Add a dummy test for JUnit
Copy link
Collaborator

@WimCrols WimCrols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better :shipit:
Consider maybe adding something to the README that this is the DE-based version which is already EOL.

@todorinskiz todorinskiz merged commit 1761738 into release-4.x May 2, 2024
10 checks passed
@todorinskiz todorinskiz deleted the ALFREDAPI-545_z branch May 2, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants