-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALFREDAPI-545 Defects and improvements v4.1.1 #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALFREDAPI-521_release [Test] import junit-jupiter:5.7.1 ALFREDAPI-521_release [Test] update upload test task ci ALFREDAPI-521_release [Test] change testImplementation 'org.junit.jupiter:junit-jupiter for gradle plugin og junit.reporter ALFREDAPI-521_release [Test] adding mikepenz/action-junit-report@v3 ALFREDAPI-521_release [Test] ALFREDAPI-521_release [Test] Junit in gradle ALFREDAPI-521_release [Test] issue ci solved ALFREDAPI-521_release [Test] test reports ALFREDAPI-521_release [Update] ci Publish Test Report - new path to include integration test results ALFREDAPI-521_release [Delete] junit.reporter ALFREDAPI-521_release [Test] Update path to include integration test ALFREDAPI-521_release [Test] revert alfresco_version to include all builds ALFREDAPI-521_release [Undo] Failing tests ALFREDAPI-521_release [Undo] test code ALFREDAPI-521_release [Cleanup] to rebase ALFREDAPI-521_release [Update] Add a 1s delay before searching for results ALFREDAPI-521_release: skip test for GHA (runs finelocally) ALFREDAPI-521_release [Update] import @ignore ALFREDAPI-521_release [Update] Add a dummy test for JUnit
todorinskiz
requested review from
WimCrols,
RVanhuysseXenit,
kpiot123,
hechmi-dammak-xenit,
codingBenVdS and
bartvl-xenit
April 25, 2024 09:26
WimCrols
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better
Consider maybe adding something to the README that this is the DE-based version which is already EOL.
todorinskiz
force-pushed
the
ALFREDAPI-545_z
branch
from
May 2, 2024 12:35
5601420
to
14ee710
Compare
RVanhuysseXenit
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes tickets from https://xenitsupport.jira.com/browse/ALFREDAPI-545 (epic)
Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-546
Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-547
Is CHANGELOG.md extended?
Does this PR avoid breaking the API?
Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
Does the PR comply to REST HTTP result codes policy outlined in the user guide?
Is error handling done through a method annotated with
@ExceptionHandler
in the webscript classes?Does the PR follow our coding styleguide and other active procedures?
Is usage of
this.
prefix avoided?@WimCrols this PR is the merge of 3 smaller PRs
Includes:
There are 2 main regressions: