Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALFREDAPI-552 update swagger spec to be oa2 compliant #222

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

RVanhuysseXenit
Copy link
Contributor

This has already been done twice without being committed to the main repository. We should make this a permanent change

Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-552

  • Is CHANGELOG.md extended?
  • Does this PR avoid breaking the API?
    Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
  • Does the PR comply to REST HTTP result codes policy outlined in the user guide?
  • [N/A] Is error handling done through a method annotated with @ExceptionHandler in the webscript classes?
  • Does the PR follow our coding styleguide and other active procedures?
  • Is usage of this. prefix avoided?

See README.md for full explanation.

@RVanhuysseXenit RVanhuysseXenit self-assigned this Jul 10, 2024
WimCrols
WimCrols previously approved these changes Jul 10, 2024
Copy link
Collaborator

@WimCrols WimCrols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to give feedback. If this runs in the appropriate tools, then it is good.

CHANGELOG.md Outdated Show resolved Hide resolved
WimCrols
WimCrols previously approved these changes Jul 10, 2024
todorinskiz
todorinskiz previously approved these changes Jul 17, 2024
docs/build.gradle Outdated Show resolved Hide resolved
docs/build.gradle Outdated Show resolved Hide resolved
…s by user with dispatch_workflow permissions
@WimCrols
Copy link
Collaborator

WimCrols commented Aug 8, 2024

Since this is not yet rebased on the 23.x support branch, the builds will not 100% work, but that's ok, we can merge after review.

docs/build.gradle Show resolved Hide resolved
@WimCrols WimCrols merged commit 564e4aa into master Aug 8, 2024
11 checks passed
@WimCrols WimCrols deleted the ALFREDAPI-552 branch August 8, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants