Support :same-site attribute #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:same-site only exists from ring-core 1.6 and higher
travis.org is EOL (see https://travis-ci.org/github/xeqi/peridot)
For `update` and `clojure.string/starts-with?`
|
Sorry I missed this PR. Could we use GitHub Actions? Everything else looks ok. |
|
I removed the CI part. So this can be tackled separately. |
jeroenvandijk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please find the following changes in this PR:
:same-site(link):same-siteattributeI can split up these commits in seperate PR's if desired.
For full support we might also need to consider updating kerodon for when following links, this should have the same behaviour as redirects in peridot (see for more explaination this page under
Differences Between the Strict and Lax SameSite Cookie Attributes