Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting edge attributes when the attribute name is set. #481

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

nwlandry
Copy link
Collaborator

Fixes #480.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (536f592) 92.03% compared to head (6bc4c4b) 92.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
+ Coverage   92.03%   92.05%   +0.02%     
==========================================
  Files          60       60              
  Lines        4392     4392              
==========================================
+ Hits         4042     4043       +1     
+ Misses        350      349       -1     
Files Coverage Δ
xgi/core/hypergraph.py 93.54% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry nwlandry merged commit 16e39f6 into main Oct 25, 2023
18 checks passed
@nwlandry nwlandry deleted the fix-480 branch October 25, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue adding edge attributes
2 participants