Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sub test traces #61

Merged
merged 1 commit into from
Apr 14, 2024
Merged

fix sub test traces #61

merged 1 commit into from
Apr 14, 2024

Conversation

xhd2015
Copy link
Owner

@xhd2015 xhd2015 commented Apr 14, 2024

When running multiple tests, only the first test gets it's full trace.

That's because when installing the trace interceptor, we set a flag to avoid duplicate, but do not remove that flag after cancelling the interceptor.

By the way, I find that trace can be simply enabled via:

defer trace.Begin()()

@xhd2015 xhd2015 force-pushed the fix-subtest-traces branch from 645b39e to 908dd18 Compare April 14, 2024 03:21
@xhd2015 xhd2015 force-pushed the fix-subtest-traces branch from 908dd18 to b32da50 Compare April 14, 2024 03:29
@xhd2015 xhd2015 merged commit b0dd187 into master Apr 14, 2024
1 check passed
@xhd2015 xhd2015 deleted the fix-subtest-traces branch April 14, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant