Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v1.0.0 #47

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Prepare v1.0.0 #47

merged 4 commits into from
Nov 21, 2023

Conversation

dinosaure
Copy link
Collaborator

No description provided.

@xvw
Copy link
Collaborator

xvw commented Nov 17, 2023

To be honest, I think putting all the tests in the yocaml_yaml package is a bit radical. I'd suggest taking the Key_Value tests and putting them in dedicated Yocaml_yaml tests and keeping the generic tests in the Yocaml package. What do you think?

@dinosaure
Copy link
Collaborator Author

You are right, it was a quick fix, I can split out tests but it will delay a bit the release.

@xvw
Copy link
Collaborator

xvw commented Nov 17, 2023

How serious is it? It seems to me that we've been waiting for the release of YOCaml for almost three years :D
But yes, as a QuickFix, I understand!

@xhtmlboi
Copy link
Owner

I can do it overnight for your time zone.

@xhtmlboi
Copy link
Owner

As v2 will probably involve a bit of reorganisation, I think we can leave it as it is ;)
The tests essentially serve the CI.

@dinosaure dinosaure merged commit b52756b into main Nov 21, 2023
2 checks passed
@dinosaure dinosaure deleted the prepare-v1.0.0 branch November 21, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants