Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yocaml_unix: use digestif for SHA256 computation instead of cryptokit #50

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

hannesm
Copy link
Contributor

@hannesm hannesm commented Feb 13, 2024

just a preference :)

@xvw
Copy link
Collaborator

xvw commented Feb 13, 2024

Hi @xhtmlboi has some issue to connect on github (since they ask for a mobile :D, we currently drafting the new proposition for YOCaml here: https://gitlab.com/funkywork/yocaml, and we will move the new version from gitlab to here) but we agree with the patch. I do not know why he chose Cryptokit on the first attempt.

Could you please just add an entry in https://github.com/xhtmlboi/yocaml/blob/main/CHANGES.md (in a section **dev (unreleased) with a subsection yocaml_unix)?

Thanks a lot.

@hannesm
Copy link
Contributor Author

hannesm commented Feb 15, 2024

sure, done in d36972c

@xvw
Copy link
Collaborator

xvw commented Feb 15, 2024

Thanks, I'll merge after the pipeline!
@dinosaure should we make a new release (or you are using a custom opam repo?)

@dinosaure
Copy link
Collaborator

@dinosaure should we make a new release (or you are using a custom opam repo?)

I see some activities on your side (on https://gitlab.com/funkywork/yocaml), we probably can wait for your work and do a big release then?

@xvw xvw merged commit 6525183 into xhtmlboi:main Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants