Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some missing features #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some missing features #99

wants to merge 2 commits into from

Conversation

CHNB128
Copy link

@CHNB128 CHNB128 commented Apr 28, 2019

  • Select all
  • Undo Redo

@patrickisgreene
Copy link
Contributor

For some reason the select all feature isn't working correctly. It seems to be displaying the new line escape sequence.
xi-term-select-all

Any idea what might be causing this?

@patrickisgreene
Copy link
Contributor

I think this is happening because of the newline sent by xi-core with each line in the line cache. A simple fix for this could be simply stripping the newline character before rendering each line, it shouldn't be necessary since we already have the text divided into lines. but i'm not sure if this is the best solution

I tested with: gnome-terminal, stterm, rxvt-unicode

@msirringhaus
Copy link

For me this is only happening with syntax highlighting active (for all kinds of multi-line selections).
Without syntect, everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants