Skip to content

Commit

Permalink
[MINOR][SQL] Remove signature from Hive thriftserver DEBUG log
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

This PR aims to remove signature from Hive thriftserver DEBUG log.

### Why are the changes needed?

This is aligned with the upstream Apache Hive project.
- apache/hive#4887

This is also aligned with the previous Spark change.
- apache#43402

### Does this PR introduce _any_ user-facing change?

No, this is a debug message removal.

### How was this patch tested?

Pass the CIs and manual review (because this is a removal).

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#49752 from dongjoon-hyun/minor_debug_msg.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
  • Loading branch information
dongjoon-hyun committed Jan 31, 2025
1 parent b62c3f4 commit 4a33e96
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ public String verifyAndExtract(String signedStr) {
String rawValue = signedStr.substring(0, index);
String currentSignature = getSignature(rawValue);

if (LOG.isDebugEnabled()) {
LOG.debug("Signature generated for " + rawValue + " inside verify is " + currentSignature);
}
if (!MessageDigest.isEqual(originalSignature.getBytes(), currentSignature.getBytes())) {
throw new IllegalArgumentException("Invalid sign");
}
Expand Down

0 comments on commit 4a33e96

Please sign in to comment.