Media Element #2147
Merged
Media Element #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clearing media elements on property save (need to refactor - see todo in widget edit) xibosignageltd/xibo-private#294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing and output for the media element, related to https://github.com/xibosignageltd/xibo-private/issues/294
Saving elements links media correctly (adding and removing), the HTML cache looks right with the
[[mediaId=x]]refs and the decorated output looks good in preview with the URL.However, the override with isn't working.
The default image for global-image is dangerous as it is a Xibo logo - it should be something generic instead.
Maintaining media links isn't working for saving the widget - it will not remove references which have been removed. We need to way to easily clear out only the library references from inside properties.