add more tests

xinlifoobar · Aug 20, 2024 · 2acd148 · 2acd148
1 parent d5b63f4
commit 2acd148
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/datafusion/functions/src/regex/regexpcount.rs b/datafusion/functions/src/regex/regexpcount.rs
@@ -119,7 +119,7 @@ fn regexp_count_func(args: &[ArrayRef]) -> Result<ArrayRef> {
         DataType::Utf8 => regexp_count::<i32>(args),
         DataType::LargeUtf8 => regexp_count::<i64>(args),
         other => {
-            internal_err!("Unsupported data type {other:?} for function regexp_like")
+            internal_err!("Unsupported data type {other:?} for function regexp_count")
         }
     }
 }

diff --git a/datafusion/sqllogictest/test_files/regexp.slt b/datafusion/sqllogictest/test_files/regexp.slt
@@ -503,6 +503,10 @@ statement error
 External error: query failed: DataFusion error: Arrow error: Compute error: regexp_count() requires start to be 1 based
 SELECT regexp_count('123123123123', '123', -3);
 
+statement error
+External error: statement failed: DataFusion error: Arrow error: Compute error: regexp_count() does not support global flag
+SELECT regexp_count('123123123123', '123', 1, 'g');
+
 query I
 SELECT regexp_count(str, '\w') from t;
 ----