use RGB888 for colours not RGB565 (#17)

xiphonics · Feb 4, 2025 · 4638f33 · 4638f33
1 parent 5820fe2
commit 4638f33
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/lib/command_builder.dart b/lib/command_builder.dart
@@ -84,11 +84,9 @@ class CmdBuilder {
       case CommandType.CLEAR:
         if (_byteBuffer.length == _type!.paramCount) {
           final cmd = ClearCmd(
-            // convert from 565 RGB to 888 RGB
-            // ref: https://stackoverflow.com/a/9069480/85472
-            r: (_byteBuffer[0] * 527 + 23) >> 5, // Red component
-            g: (_byteBuffer[1] * 259 + 33) >> 6, // Green component
-            b: (_byteBuffer[2] * 527 + 23) >> 5, // Blue component
+            r: _byteBuffer[0],
+            g: _byteBuffer[1],
+            b: _byteBuffer[2],
           );
           _commandStreamController.add(cmd);
           _reset();
@@ -99,11 +97,9 @@ class CmdBuilder {
       case CommandType.SET_COLOUR:
         if (_byteBuffer.length == _type!.paramCount) {
           final cmd = ColourCmd(
-            // convert from 565 RGB to 888 RGB
-            // ref: https://stackoverflow.com/a/9069480/85472
-            r: (_byteBuffer[0] * 527 + 23) >> 5, // Red component
-            g: (_byteBuffer[1] * 259 + 33) >> 6, // Green component
-            b: (_byteBuffer[2] * 527 + 23) >> 5, // Blue component
+            r: _byteBuffer[0],
+            g: _byteBuffer[1],
+            b: _byteBuffer[2],
           );
           _commandStreamController.add(cmd);
           _reset();