Skip to content

Commit

Permalink
Combine build ext and build ext media tasks
Browse files Browse the repository at this point in the history
Previously I split these up since I wasn't sure if we wanted finer grained control over them. Sounds like having them combined is more convenient
  • Loading branch information
mjbvz committed May 5, 2021
1 parent e8c4f47 commit 9be6a24
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 47 deletions.
44 changes: 2 additions & 42 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,39 +55,11 @@
}
}
},
{
"type": "npm",
"script": "watch-extension-mediad",
"label": "Ext Media - Build",
"isBackground": true,
"presentation": {
"reveal": "never",
"group": "buildWatchers"
},
"problemMatcher": {
"owner": "typescript",
"applyTo": "closedDocuments",
"fileLocation": [
"absolute"
],
"pattern": {
"regexp": "Error: ([^(]+)\\((\\d+|\\d+,\\d+|\\d+,\\d+,\\d+,\\d+)\\): (.*)$",
"file": 1,
"location": 2,
"message": 3
},
"background": {
"beginsPattern": "Starting compilation",
"endsPattern": "Finished compilation"
}
}
},
{
"label": "VS Code - Build",
"dependsOn": [
"Core - Build",
"Ext - Build",
"Ext Media - Build",
"Ext - Build"
],
"group": {
"kind": "build",
Expand Down Expand Up @@ -117,23 +89,11 @@
},
"problemMatcher": "$tsc"
},
{
"type": "npm",
"script": "kill-watch-extension-mediad",
"label": "Kill Ext Media - Build",
"group": "build",
"presentation": {
"reveal": "never",
"group": "buildKillers"
},
"problemMatcher": "$tsc"
},
{
"label": "Kill VS Code - Build",
"dependsOn": [
"Kill Core - Build",
"Kill Ext - Build",
"Kill Ext Media - Build",
"Kill Ext - Build"
],
"group": "build",
"problemMatcher": []
Expand Down
7 changes: 2 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"preinstall": "node build/npm/preinstall.js",
"postinstall": "node build/npm/postinstall.js",
"compile": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js compile",
"watch": "npm-run-all -lp watch-client watch-extensions watch-extension-media",
"watch": "npm-run-all -lp watch-client watch-extensions",
"watchd": "deemon yarn watch",
"watch-webd": "deemon yarn watch-web",
"kill-watchd": "deemon --kill yarn watch",
Expand All @@ -24,12 +24,9 @@
"watch-client": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js watch-client",
"watch-clientd": "deemon yarn watch-client",
"kill-watch-clientd": "deemon --kill yarn watch-client",
"watch-extensions": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js watch-extensions",
"watch-extension-media": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js watch-extension-media",
"watch-extensions": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js watch-extensions watch-extension-media",
"watch-extensionsd": "deemon yarn watch-extensions",
"kill-watch-extensionsd": "deemon --kill yarn watch-extensions",
"watch-extension-mediad": "deemon yarn watch-extension-media",
"kill-watch-extension-mediad": "deemon --kill yarn watch-extension-media",
"mocha": "mocha test/unit/node/all.js --delay",
"precommit": "node build/hygiene.js",
"gulp": "node --max_old_space_size=8192 ./node_modules/gulp/bin/gulp.js",
Expand Down

0 comments on commit 9be6a24

Please sign in to comment.