Skip to content

Commit

Permalink
Make max_submit parameter function instead
Browse files Browse the repository at this point in the history
  • Loading branch information
xjules committed Dec 13, 2023
1 parent 3e725e8 commit 8364762
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
6 changes: 2 additions & 4 deletions src/ert/scheduler/job.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def driver(self) -> Driver:
return self._scheduler.driver

async def __call__(
self, start: asyncio.Event, sem: asyncio.BoundedSemaphore
self, start: asyncio.Event, sem: asyncio.BoundedSemaphore, max_submit: int = 2
) -> None:
await start.wait()
retries = 0
Expand Down Expand Up @@ -97,18 +97,16 @@ async def __call__(
else:
await self._send(State.FAILED)
retries += 1
retry = retries < self._scheduler._max_submit
retry = retries < max_submit
if retry:
message = f"Realization: {self.iens} failed, resubmitting"
logger.warning(message)
print(message)
else:
message = (
f"Realization: {self.iens} "
"failed after reaching max submit "
f"{self._scheduler._max_submit}!"
)
print(message)
logger.error(message)

except asyncio.CancelledError:
Expand Down
3 changes: 2 additions & 1 deletion src/ert/scheduler/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def __init__(self, driver: Optional[Driver] = None) -> None:
self._tasks: MutableMapping[int, asyncio.Task[None]] = {}

self._events: Optional[asyncio.Queue[Any]] = None
# will be read from QueueConfig
self._max_submit: int = 2

self._ee_uri = ""
Expand Down Expand Up @@ -121,7 +122,7 @@ async def execute(
start = asyncio.Event()
sem = asyncio.BoundedSemaphore(semaphore._initial_value if semaphore else 10) # type: ignore
for iens, job in self._jobs.items():
self._tasks[iens] = asyncio.create_task(job(start, sem))
self._tasks[iens] = asyncio.create_task(job(start, sem, self._max_submit))

start.set()
for task in self._tasks.values():
Expand Down

0 comments on commit 8364762

Please sign in to comment.