Bugfix/94 compatibility matrix #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update compatibility with Gixy, Stylelint and Markdow-lint. Snyk and Sonar-scanner are still yet to be added. After updating the compatibility matrix, the results_summary.py should also be updated so that the correct "status" message will be displayed after the linter is used in the scan.
They support checking through "node_modules", which then runs the check across the entire project. Setup for using Snyk: - Create a Snyk account - Skip the creating a project process - Go to Account Settings (In the bottom left) > General - Save and use the API token as a secret in the Snyk configuration Setup for using SonarScanner: - Download sonar from [here](https://www.sonarsource.com/products/sonarqube/downloads/) - Go to sonarqube-<version>/bin/<your-os>/ - Run sonar.sh if you're on Linux/MacOS or StartSonar.bat if you're on windows - Set your credentials - Create a project (select manually, not through a devops platform) - Set a display name and a **project_key** - Now that you have a project created go to My Account > Security - Create a user_token (starts with "squ" and is used for authentication in configuration) - The configuration secret will be the user_token - The config file should contain at least: ``` sonar.host.url= # http://localhost:9000/ if being run locally sonar.projectKey= # The **project_key** created earlier ``` In the current state of sonar_scanner.py, the following warning is going to be issued during the scan: > WARN: The property 'sonar.login' is deprecated and will be removed in > the future. Please use the 'sonar.token' property > instead when passing a token. This is easily fixed by changing the `-Dsonar.login=` part in `sonar_scanner.py`'s run_command to `-Dsonar.token=`. In the case of sonar-scanner, the results of your scan are also going to be visible on http://localhost:9000/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the five remaining checks (markdown-lint, stylelint, gixy, sonar-scanner, snyk) to the compatibility matrix.
The checks are going to have to also be added to
results_summary.pyso as to avoid the"Not fully supported yet" status.
In
sonar_scanner.pythe-Dsonar.login=argument should be fixed to-Dsonar.token=.At the moment Gixy requires Nginx to be installed to work, this is still yet to be fixed.