Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade platform requirements #122

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aehlke
Copy link

@aehlke aehlke commented Feb 17, 2023

note: I haven't tried macOS yet

@mlorenze
Copy link
Contributor

Hi @aehlke!
Thank you for using our framework and contributing to it.
Related with downgrading to iOS15, there are issues with that when working with BarButtonStyle styles (is not showing the navBar).
So we won't update the framework with this PR.

@aehlke
Copy link
Author

aehlke commented Feb 17, 2023

Hi @mlorenze your library works just fine on iOS 15 with the segmented style, which is the only way I use your lib. So I'd like to be able to continue to use the bar styles that do work on iOS 15. I noticed that your iOS 16 requirements were isolated to specific bar styles rather than various features scattered throughout, so I saw an opportunity to allow per style OS compatibility.

The bar styles that do work (segmented, at least) are fantastic: it's the native Apple UI which is a good default and common need. Please don't artificially prevent this bar style from being used when it works and looks like it'll continue to work on older versions given its simplicity in implementation compared with the custom UI styles.

As an aside, supporting not even 1 version back for a lib is a bit scary. I do that with my own apps sometimes, but am not always eager to shed the tens of % of users from one version back (not even a year out of date yet). This PR would at least allow falling back to native segmented control UI without forcing users to upgrade to an OS not even a year old yet.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants