Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added expo support #126

Merged
merged 8 commits into from
Dec 26, 2024
Merged

Conversation

ardasatata
Copy link
Contributor

PR Title

🔄 Type of change:

  • ✨Feature/chore
  • ♻️ Refactor
  • 🔧 Bugfixes

✏️ Description:

Added expo support, hence expo users can easily generate native projects using expo plugin.


📌 Notes:

  • Removed apply plugin: "kotlin-android-extensions" on build.gradle since it's causing android build fails

⚠️ Warnings:

  • It might only support Expo SDK >= 51, I haven't tested with older SDK
  • AppDelegate is quite unstable, might not work properly if it's combined with other plugin such as firebase

@ardasatata
Copy link
Contributor Author

ardasatata commented Nov 10, 2024

Hi @emibotti @nicoache1 I've added expo support in this PR, hopefully, you could review & test it, as it might be useful to the community, Cheers!

@ardasatata ardasatata mentioned this pull request Nov 10, 2024
@franbe7
Copy link
Contributor

franbe7 commented Nov 15, 2024

Hi @ardasatata, we are planning to make some updates and improvements to the library soon, so we'll take this into account. Thanks for contributing and stay tuned!

Copy link
Contributor

@franbe7 franbe7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franbe7 franbe7 merged commit 0cc781c into xmartlabs:master Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants