chore: test coverage for append variants

xmidt-org · Aug 19, 2024 · 135a281 · 135a281
1 parent 92c2529
commit 135a281
Showing 1 changed file with 54 additions and 23 deletions.
diff --git a/approver_test.go b/approver_test.go
@@ -53,32 +53,63 @@ func (suite *ApproversTestSuite) TestAuthorize() {
 		},
 	}
 
-	for _, testCase := range testCases {
-		suite.Run(testCase.name, func() {
-			var (
-				testCtx   = suite.testContext()
-				testToken = suite.testToken()
-				as        Approvers[string]
-			)
+	suite.Run("Append", func() {
+		for _, testCase := range testCases {
+			suite.Run(testCase.name, func() {
+				var (
+					testCtx   = suite.testContext()
+					testToken = suite.testToken()
+					as        Approvers[string]
+				)
 
-			for _, err := range testCase.results {
-				err := err
-				as = as.Append(
-					ApproverFunc[string](func(ctx context.Context, resource string, token Token) error {
-						suite.Same(testCtx, ctx)
-						suite.Equal(testToken, token)
-						suite.Equal(placeholderResource, resource)
-						return err
-					}),
+				for _, err := range testCase.results {
+					err := err
+					as = as.Append(
+						ApproverFunc[string](func(ctx context.Context, resource string, token Token) error {
+							suite.Same(testCtx, ctx)
+							suite.Equal(testToken, token)
+							suite.Equal(placeholderResource, resource)
+							return err
+						}),
+					)
+				}
+
+				suite.Equal(
+					testCase.expectedErr,
+					as.Approve(testCtx, placeholderResource, testToken),
+				)
+			})
+		}
+	})
+
+	suite.Run("AppendFunc", func() {
+		for _, testCase := range testCases {
+			suite.Run(testCase.name, func() {
+				var (
+					testCtx   = suite.testContext()
+					testToken = suite.testToken()
+					as        Approvers[string]
 				)
-			}
 
-			suite.Equal(
-				testCase.expectedErr,
-				as.Approve(testCtx, placeholderResource, testToken),
-			)
-		})
-	}
+				for _, err := range testCase.results {
+					err := err
+					as = as.AppendFunc(
+						func(ctx context.Context, resource string, token Token) error {
+							suite.Same(testCtx, ctx)
+							suite.Equal(testToken, token)
+							suite.Equal(placeholderResource, resource)
+							return err
+						},
+					)
+				}
+
+				suite.Equal(
+					testCase.expectedErr,
+					as.Approve(testCtx, placeholderResource, testToken),
+				)
+			})
+		}
+	})
 }
 
 func (suite *ApproversTestSuite) TestAny() {